Salary changes to paid langing pages #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Trello card https://trello.com/c/1hEfOnoc/6542-update-paid-advertising-landing-pages-to-mention-starting-salary ### Context The advertising team can’t promote the new £31k starting salary until after the consultation period - and their advertising schedules mean that they can’t start running ads with the new salary amount until the new year We've added the new £31k to three pages, agreed with the advertising team. ### Changes proposed in this pull request ### Guidance to review
github-actions
bot
added
ruby
martyn-w
reviewed
Sep 19, 2024
| @@ -2,7 +2,7 @@ | |||
| <div class="col col-full-content"> | |||
| <%= render Content::PurpleBoxComponent.new( | |||
| heading: "Find out more about getting into teaching", | |||
| text: "Explore how you can get into teaching primary or secondary and find top tips on making a successful application.", | |||
| text: "Explore how you can get into teaching primary or secondary and find top tips on making a successful application. With a competitive starting salary of <%= v :salaries_starting_min %> (or higher in London), it pays to do what you love. | |||
There was a problem hiding this comment.
Don't use <%= xxx %> (line 5) brackets inside of <%= xxx %> brackets (line 3). Try using the $form$ instead.
Sarah-DfE
commented
Sep 19, 2024
app/views/content/landing/how-to-become-a-teacher/_promo.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/landing/train-to-teach-if-you-have-a-degree/_promo.html.erb
Show resolved
Hide resolved
Sarah-DfE
commented
Sep 19, 2024
app/views/content/landing/how-to-become-a-teacher/_promo.html.erb
Outdated
Show resolved
Hide resolved
Sarah-DfE
commented
Sep 19, 2024
app/views/content/landing/how-to-become-a-teacher/_promo.html.erb
Outdated
Show resolved
Hide resolved
Sarah-DfE
commented
Sep 19, 2024
Sarah-DfE
commented
Sep 19, 2024
| @@ -7,7 +7,8 @@ | |||
| checklist: [ | |||
| "career progression ", | |||
| "personal development", | |||
| "opportunities to increase your pay" | |||
| "opportunities to increase your pay", | |||
| "a starting salary of $salaries_starting_min$ (or higher in London)", | |||
There was a problem hiding this comment.
@Sarah-DfE I agree with your suggestion - these two bullets would probably make more sense the other way round, so starting salary is third (or maybe even first, if we are using a more linear order!) and increase pay is lower down that starting salary
|
Review app deployed to https://get-into-teaching-app-review-4205.test.teacherservices.cloud |
gemmadallmandfe
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/1hEfOnoc/6542-update-paid-advertising-landing-pages-to-mention-starting-salary
Context
The advertising team can’t promote the new £31k starting salary until after the consultation period - and their advertising schedules mean that they can’t start running ads with the new salary amount until the new year
We've added the new £31k to three pages, agreed with the advertising team.
Changes proposed in this pull request
Guidance to review